MAINT: Replace calls to hanning with hann
#5955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a nitpick over internal calls to the hann window. Users who request `hanning` still get the expected result. Quoting the hann window docsctring: ``` The window was named for Julius von Hann, an Austrian meteorologist. [...] It is sometimes erroneously referred to as the "Hanning" window, from the use of "hann" as a verb in the original paper and confusion with the very similar Hamming window. ```
@@ master #5955 diff @@
======================================
Files 238 238
Stmts 43727 43727
Branches 8205 8205
Methods 0 0
======================================
- Hit 34152 34150 -2
- Partial 2601 2602 +1
- Missed 6974 6975 +1
|
|
LGTM, ready for merge from your end? |
|
Pulling the trigger... |
e-q
added a commit
that referenced
this pull request
Mar 10, 2016
MAINT: Replace calls to `hanning` with `hann`
rgommers
added
scipy.signal
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a nitpick over internal calls to the hann window. Users who request
hanningstill get the expected result.Quoting the hann window docsctring: