DOC: Cleanup wav read/write docs and add tables for common types #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also I think it's a bug that |
@@ master #5991 diff @@
======================================
Files 238 238
Stmts 43768 43768
Branches 8221 8221
Methods 0 0
======================================
Hit 34197 34197
Partial 2602 2602
Missed 6969 6969
|
| Return the sample rate (in samples/sec) and data from a WAV file. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| filename : string or open file handle | ||
| Input wav file. | ||
| Input wav file. This can be an open file or a filename. |
There was a problem hiding this comment.
I don't think we need this since it's in the types above?
There was a problem hiding this comment.
Yeah, I just moved it from the Notes section
There was a problem hiding this comment.
I don't think we really need it either place -- seems clear enough from the enumerated types. WDYT?
larsoner
added
scipy.signal
Documentation
|
Ok, changed those things and rebased |
Add tables clarifying that 8-bit is unsigned, giving max and min values
|
Thanks @endolith |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.