MAINT: Some improvements to optimize._numdiff #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ master #6031 diff @@
======================================
Files 238 238
Stmts 43822 43820 -2
Branches 8215 8214 -1
Methods 0 0
======================================
- Hit 34253 34251 -2
Partial 2602 2602
Missed 6967 6967
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I slightly changed (simplify) API for
approx_derivativeandcheck_derivativeto make it easier to use as a public functions (which I do sometimes).Maybe it would be possible to move these two function to public. Also we can try to integrate them more into optimize module, suggested in #6026.