BUG: savemat does not save keys starting with underscore #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ master #6053 diff @@
======================================
Files 238 238
Stmts 43865 43863 -2
Branches 8219 8218 -1
Methods 0 0
======================================
Hit 34293 34293
+ Partial 2604 2603 -1
+ Missed 6968 6967 -1
|
|
Roundtrip test needed, plus needs to be mentioned in release notes as a backward incompatible change. |
|
@daskol could you please address the review comments? |
|
@rgommers thanks for reminding, I will address them during this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket #6052.