TST: special: better test for gammainc at large arguments #6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nobody merge this until I add tests for |
|
Ok, I think this is ready for review now. I had hoped to have one data file for both
so that didn't work out. As a result there is just a test for Finally, the function |
The previous TestSystematic test for large arguments used the exception_to_nan wrapper and as a result only checked about 183 points because of exceptions in mpmath. Unfortunately these points were in the uninteresting regions where a >> x (gammainc = 1) or a << x (gammainc = 0). This adds a test to test_data that better checks the region a ~ x, though it is restricted to a <= x because of prohibitive precomputation times in mpmath (> 1 day). Since the utilities in test_mpmath.py are also useful in test_precompute_*.py tests, they have been moved to a new file _mptestutils.py. Finally, a new function mpf2float is added to convert mpfs to floats because just using float() has incorrect rounding in some cases.
|
Rebased and force-pushed. |
pv
added
scipy.special
and removed
needs-work
|
Thanks, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the systematic test for gammainc at large arguments to be
based on data precomputed by mpmath. This allows the test to have a
much larger range and run faster. (Note that although the previous
test at large values nominally had an upper bound of 1e100, only about
183 points were actually tested because the others raised exceptions
in mpmath.)
Since the utilities in test_mpmath are also useful in precompute
tests, they have been moved to the new file _mptestutils.py.