ENH: special: extend sici/shichi to complex arguments
#6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds references and clarifies behavior on the negative real axis.
| cdef void shichi(double x0, double *y0, double *y1) nogil | ||
| cdef void sici(double x0, double *y0, double *y1) nogil | ||
| cdef void shichi(Dd_number_t x0, Dd_number_t *y0, Dd_number_t *y1) nogil | ||
| cdef void sici(Dd_number_t x0, Dd_number_t *y0, Dd_number_t *y1) nogil |
There was a problem hiding this comment.
Not related to this PR, but to gh-6195 --- it needs to be understood what problems this sort of signature changes can cause to existing Cython code. I think this is similar to an ABI break --- changing signatures here will require recompilation of Cython modules using these exported functions.
There was a problem hiding this comment.
However, unlike ABI break, this should raise an exception rather than segfaulting since Cython checks the signatures. It may nevertheless require some thinking on how what sort of ABI change policy we want here.
There was a problem hiding this comment.
Just to confirm--you get an error like this:
ImportError: scipy.special.cython_special does not export expected C function sici
| \gamma + \log(x) + \int_0^x \frac{\cosh{t} - 1}{t} dt | ||
|
|
||
| where :math:`\gamma` is Euler's constant and :math:`\log` is the | ||
| principle branch of the logarithm. |
|
LGTM, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-1430.