-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert gh-5938, restore ks_2samp #6545
Conversation
This reverts commit 2f1720a. Conflicts: doc/release/0.18.0-notes.rst scipy/stats/_stats.pyx scipy/stats/setup.py scipy/stats/stats.py
Agreed, if it's not clearly correct, then it probably doesn't have too much value. |
I suggest to remove it and open a new issue that explains the history and what has to be done to get the faster version of |
Since it's no longer used. It was added in scipygh-5938 for scipy 0.18.0 to get some speedup for ks_2samp, but then the addition was reverted in scipygh-6545, following the discussion in scipygh-6435: it gives different answers on different machines, it changes one ad hoc statistic to a different ad hoc statistic, and neither of them are clearly "correct".
OK, dead code is gone. |
In it goes then. Thanks @ev-br |
Since it's no longer used. It was added in scipygh-5938 for scipy 0.18.0 to get some speedup for ks_2samp, but then the addition was reverted in scipygh-6545, following the discussion in scipygh-6435: it gives different answers on different machines, it changes one ad hoc statistic to a different ad hoc statistic, and neither of them are clearly "correct".
backported in gh-6557 |
As discussed in gh-6435,
ks_2samp
for scipy 0.18.0,Therefore, this PR simply reverts gh-5938 and restores the implementation of
stats.ks_2samp
from scipy 0.17.0 so that we keep backwards compatibility until someone steps up for 4. above.Points to consider:
ks_2samp
in_stats.pyx
which is there but unused. Do we want to keep it in the source code, or we're fine with it surviving in the git history only?