Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: sparse: instantiate lil_matrix with data #6617

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ENH: sparse: instantiate lil_matrix with data #6617

wants to merge 3 commits into from

Conversation

VP468
Copy link

@VP468 VP468 commented Sep 24, 2016 •
edited by rgommers
Loading

closes gh-6613

@rgommers rgommers added scipy.sparse maintenance Items related to regular maintenance tasks enhancement A new feature or improvement and removed maintenance Items related to regular maintenance tasks labels Sep 25, 2016
@rgommers rgommers changed the title changes for issue# 6613 ENH: instantiate sparse.lil_matrix with data Sep 25, 2016
@rgommers
Copy link
Member

Thanks @VP468. I edited your title to be a bit more descriptive. You may also want to format your commit messages like this in the future.

Also restarted the build, problem was unrelated to this PR.

@rgommers
Copy link
Member

Tests still failing after the second commit:

======================================================================
ERROR: test_base.Test64Bit.test_no_64(<class 'test_base.TestLIL'>, 'test_init')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "<decorator-gen-24>", line 2, in check
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 146, in deco
    return func(*a, **kw)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 4385, in check
    getattr(instance, method_name)()
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'int'

======================================================================
ERROR: test_base.Test64Bit.test_resiliency_all_32(<class 'test_base.TestLIL'>, 'test_init')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "<decorator-gen-26>", line 2, in check
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 146, in deco
    return func(*a, **kw)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 4385, in check
    getattr(instance, method_name)()
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'int'

======================================================================
ERROR: test_base.Test64Bit.test_resiliency_all_64(<class 'test_base.TestLIL'>, 'test_init')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "<decorator-gen-28>", line 2, in check
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 146, in deco
    return func(*a, **kw)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 4385, in check
    getattr(instance, method_name)()
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'

======================================================================
ERROR: test_base.Test64Bit.test_resiliency_limit_10(<class 'test_base.TestLIL'>, 'test_init')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "<decorator-gen-30>", line 2, in check
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 146, in deco
    return func(*a, **kw)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 4385, in check
    getattr(instance, method_name)()
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'int'

======================================================================
ERROR: test_base.Test64Bit.test_resiliency_random(<class 'test_base.TestLIL'>, 'test_init')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "<decorator-gen-32>", line 2, in check
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 146, in deco
    return func(*a, **kw)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 4385, in check
    getattr(instance, method_name)()
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'long'

======================================================================
ERROR: test_base.TestLIL.test_init
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/tests/test_base.py", line 3770, in test_init
    assert_equal(A[0,0],1)
  File "/home/travis/virtualenv/python3.5.2/lib/python3.5/site-packages/scipy/sparse/lil.py", line 270, in __getitem__
    i, j)
  File "scipy/sparse/_csparsetools.pyx", line 18, in scipy.sparse._csparsetools.lil_get1 (scipy/sparse/_csparsetools.c:2582)
ValueError: Buffer dtype mismatch, expected 'Python object' but got 'int'

@VP468
Copy link
Author

VP468 commented Sep 25, 2016

Thanks for restarting the build @rgommers! I fixed the error with my latest commit.

@pv
Copy link
Member

pv commented Sep 26, 2016 via email

@pv pv added the needs-work Items that are pending response from the author label Oct 8, 2016
@lucascolley lucascolley changed the title ENH: instantiate sparse.lil_matrix with data ENH: instantiate sparse.lil_matrix with data Jun 2, 2024
@lucascolley lucascolley changed the title ENH: instantiate sparse.lil_matrix with data ENH: sparse: instantiate lil_matrix with data Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement A new feature or improvement needs-work Items that are pending response from the author scipy.sparse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot instantiate sparse.lil_matrix() with data
3 participants
@VP468 @rgommers @pv