MAINT: Bump Cython version #8030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci-skip] Closes #7987.
|
One more version to bump here: https://github.com/scipy/scipy/blob/master/tools/cythonize.py#L58. Could be others I don't know about. |
person142
reviewed
Oct 13, 2017
tools/cythonize.py
Outdated
| raise Exception('Building SciPy requires Cython >= 0.23.4') | ||
|
|
||
| # Try to find pyproject.toml | ||
| pyproject_toml = os.path.join(dirname(dirname(__file__)), "pyproject.toml") |
There was a problem hiding this comment.
Ha yes that's a more elegant way to solve the problem.
There was a problem hiding this comment.
It works!
Building, see build.log...
Running scipy/linalg/_generate_pyx.py
Running scipy/special/_generate_pyx.py
Processing scipy/_lib/_ccallback_c.pyx
Processing scipy/_lib/messagestream.pyx
Processing scipy/cluster/_hierarchy.pyx
Traceback (most recent call last):
File "/home/ubuntu/scipy/tools/cythonize.py", line 283, in <module>
main()
File "/home/ubuntu/scipy/tools/cythonize.py", line 279, in main
find_process_files(root_dir)
File "/home/ubuntu/scipy/tools/cythonize.py", line 268, in find_process_files
for result in pool.imap(lambda args: process(*args), jobs):
File "/opt/circleci/python/2.7.11/lib/python2.7/multiprocessing/pool.py", line 668, in next
raise value
Exception: Building SciPy requires Cython >= 0.25
Processing scipy/cluster/_optimal_leaf_ordering.pyx
Processing scipy/cluster/_vq.pyx
Processing scipy/interpolate/_bspl.pyx
Processing scipy/interpolate/_ppoly.pyx
Processing scipy/interpolate/interpnd.pyx
Processing scipy/io/matlab/mio5_utils.pyx
Processing scipy/io/matlab/mio_utils.pyx
Processing scipy/io/matlab/streams.pyx
Processing scipy/linalg/_decomp_update.pyx.in
There was a problem hiding this comment.
I'd prefer join(dirname(__file__), '..', '..', 'pyproject.toml') over the iterated dirname.
There was a problem hiding this comment.
I think you have an extra .. in there, but will do.
|
Thanks @xoviat. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci-skip]
Closes #7987.