Unhelpful error message when calling scipy.sparse.save_npz on a dok_matrix #7718 #8049
Conversation
…d if unimplemented sparse format is used.
scipy/sparse/_matrix_io.py
Outdated
| @@ -72,7 +69,9 @@ def save_npz(file, matrix, compressed=True): | |||
| arrays_dict.update(row=matrix.row, col=matrix.col) | |||
| else: | |||
| raise NotImplementedError('Save is not implemented for sparse matrix of format {}.'.format(matrix.format)) | |||
|
|
|||
| arrays_dict = dict(format=matrix.format.encode('ascii'), | |||
There was a problem hiding this comment.
This should update arrays_dict, not overwrite it.
perimosocordiae
added
defect
|
Thanks for the fix! Can you also add a test to scipy/sparse/tests/test_matrix_io.py that tries to call |
…tempt to save an unsupoorted type is made.
scipy/sparse/tests/test_matrix_io.py
Outdated
| x[0,1] = 1 | ||
| save_npz('x.npz', x) | ||
|
|
||
| assert_raises(NotImplementedError, save_dok) |
There was a problem hiding this comment.
Can you have the assert_raises just check save_npz? That is:
x = dok_matrix(...)
...
assert_raises(NotImplementedError, save_npz, 'x.npz', x)
scipy/sparse/tests/test_matrix_io.py
Outdated
| @@ -7,11 +7,11 @@ | |||
|
|
|||
| import pytest | |||
| from pytest import raises as assert_raises | |||
| from numpy.testing import assert_equal, assert_ | |||
| from numpy.testing import assert_equal, assert_, assert_raises | |||
There was a problem hiding this comment.
This assert_raises isn't needed, as we're getting it from the import on the previous line.
There was a problem hiding this comment.
I made the change but can you please explain the advantage of implementing it as you suggested?
There was a problem hiding this comment.
We're moving from nose to pytest. The version from numpy.testing is from nose, whereas the one imported on line 9 is from pytest. They do the same thing, but since we no longer require users to install nose to run the tests, we can't rely on numpy.testing.assert_raises being available.
|
Merged. Thanks again, @RothNRK ! |
#7718
The comments in the issue were implemented and now a
NotImplementedError: Save is not implemented for sparse matrix of format {}.error is raised.