BUG: fix solve_lyapunov import #8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `scipy.linalg.solve_lyapunov` is not importable. The documentation says: "The old name is kept for backwards-compatibility." https://docs.scipy.org/doc/scipy/reference/release.1.0.0.html#other-changes However, the old name is missing from `__all__`, so it is not picked up by `__init__.py`, despite the request in issue #6622 which sparked the rename: #6622 (comment)
|
I should have caught this. Thank you for the PR. It's actually #7105 which actually made the change (for the record). |
ilayn
added
backport-candidate
mihaic
added a commit
to mihaic/pymanopt
that referenced
this pull request
Oct 25, 2017
In SciPy 1.0.0, `scipy.linalg.solve_lyapunov` is not importable. See this PR for details: scipy/scipy#8082 Signed-off-by: Mihai Capotă <mihai@mihaic.ro>
Merged
rgommers
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
scipy.linalg.solve_lyapunovis not importable.The documentation says:
"The old name is kept for backwards-compatibility."
https://docs.scipy.org/doc/scipy/reference/release.1.0.0.html#other-changes
However, the old name is missing from
__all__, so it is not picked upby
__init__.py, despite the request in issue #6622 which sparked therename:
#6622 (comment)