Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: missing check on minkowski w kwarg #8156

Merged
merged 1 commit into from
Nov 15, 2017
Merged

BUG: missing check on minkowski w kwarg #8156

merged 1 commit into from
Nov 15, 2017

Conversation

apbard
Copy link
Contributor

@apbard apbard commented Nov 13, 2017

fixes #8142

@apbard apbard mentioned this pull request Nov 13, 2017
Closed
@rgommers rgommers added backport-candidate This fix should be ported by a maintainer to previous SciPy versions. maintenance Items related to regular maintenance tasks scipy.spatial labels Nov 14, 2017
@rgommers
Copy link
Member

Thanks @apbard. Could you add a regression test?

@rgommers
Copy link
Member

TravisCI test failure is unrelated, that's the updateifcopy deprecation.

@apbard
Copy link
Contributor Author

apbard commented Nov 14, 2017

Could you add a regression test?

I forgot to push it...added it now.

@rgommers rgommers added this to the 1.0.1 milestone Nov 15, 2017
@rgommers rgommers merged commit 24f9b33 into scipy:master Nov 15, 2017
@rgommers
Copy link
Member

LGTM, merged. Thanks @apbard

@rgommers rgommers mentioned this pull request Mar 19, 2018
Merged
@rgommers rgommers removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.spatial
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

scipy-v1.0.0 pdist with metric=minkowski raises ValueError: array must not contain infs or NaNs
2 participants
@apbard @rgommers