BUG: optimize: fix bug when variables fixed by bounds are inconsistent with constraints #8237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| method=self.method) | ||
| _assert_infeasible(res) | ||
|
|
||
| def test_bounds_equal_but_infeasible2(self): |
There was a problem hiding this comment.
There's probably some potential to reduce code duplication via a parametrized pytest approach since the input data is the same for both tests with the exception of the argument specifications (i.e., A_eq vs. A_ub). I'm not sure it would be that much cleaner though since you'd likely need to specify the default None argument for i.e., A_eq when using A_ub, but just a thought given the test similarities.
A pytest fixture might be another option or something that could be used in combination so the parametrization isn't too bulky.
|
thanks, lgtm |
pv
added
the
backport-candidate
rgommers
pushed a commit
to rgommers/scipy
that referenced
this pull request
Mar 17, 2018
(cherry-pick of the 3 commits in scipygh-8237)
Merged
rgommers
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8234