REV: reintroduce csgraph import in scipy.sparse #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the discussion in gh-8280, I'm +1 for merging this. |
rgommers
added
scipy.sparse.csgraph
maintenance
|
Is this not mentioned in the 1.0.0 release notes:
How about backport it to the 0.19 and 1.0 maintenance branches, don't include in master, and make sure it's made clear in the release notes for the next release that it's been removed? |
|
It's about whether scipy.sparse.csgraph is available after "import
scipy.sparse" or not. I think we don't have good reasons for making it
unavailable, as long as there are non-deprecated functions in
scipy.sparse.csgraph.
|
scipy/sparse/__init__.py
Outdated
| @@ -237,6 +237,9 @@ | |||
| from .extract import * | |||
| from ._matrix_io import * | |||
|
|
|||
| # For backward compatibility with v0.19. This function is marked as deprecated. | |||
There was a problem hiding this comment.
csgraph is a module, not a function. I'd just leave the bit about back-compat.
APwhitehat
force-pushed
the
SCIPY-8243
branch
from
2fef59a
to
66f886d
Compare
Merged
rgommers
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reintroduce csgraph import in scipy.sparse as suggested in #8243