ENH: in scipy.sparse.linalg.norm implement spectral norm #8472
Conversation
|
Some comments here:
|
|
Ok, thanks for comment! I fixed this things. |
|
Ok, without csc_matrix and info about float in matrix - svds raise error
With this it works correctly. |
|
@c-f-h everything is ok now? |
|
I think that it can be merge? |
| from scipy.sparse.linalg import svds | ||
| x = csc_matrix(x, dtype=float) | ||
| u, s, vt = svds(x, k=1) | ||
| return s[0] |
There was a problem hiding this comment.
The spectral norm algorithm is duplicated here, right? It might be more suitable to define a function and call it for the conditions where a spectral norm is to be used, as the duplication of code could be a maintenance burden.
| ====== ============================ | ||
| None Frobenius norm | ||
| 'fro' Frobenius norm | ||
| 'spec' Spectral norm |
There was a problem hiding this comment.
Don't add the 'spec' alias, the ord=2 is sufficient.
| from scipy.sparse.linalg import svds | ||
| x = csc_matrix(x, dtype=float) | ||
| u, s, vt = svds(x, k=1) | ||
| return s[0] |
| if ord in (2, 'spec'): | ||
| # spectral norm | ||
| from scipy.sparse import csc_matrix | ||
| from scipy.sparse.linalg import svds |
There was a problem hiding this comment.
The imports should be on top of the file.
| # spectral norm | ||
| from scipy.sparse import csc_matrix | ||
| from scipy.sparse.linalg import svds | ||
| x = csc_matrix(x, dtype=float) |
There was a problem hiding this comment.
The conversion to csc_matrix shouldn't be necessary.
Moreover, one also has to be able to compute norms of complex matrices.
ENH: in scipy.sparse.linalg.norm implement spectral norm
Reference to: #7268