BUG: io/matlab: work around issue in to_writeable on PyPy #8484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In to_writeable, mark numpy scalars explicitly as non-mappings. This is how it works on CPython (numpy scalar instances don't have a __dict__), but on PyPy-5.10, objects defined by C extensions have a __dict__, which confuses the code here.
|
Maybe worth linking to https://bitbucket.org/pypy/pypy/issues/2763/cpyext-defined-class-instances-always-have to see what the PyPy folks have to say. |
person142
added
defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In to_writeable, mark numpy scalars explicitly as non-mappings.
This is how it works on CPython (numpy scalar instances don't have a
__dict__), but on PyPy-5.10, objects defined by C extensions have a__dict__, which confuses the code here.After this (and the other PyPy PRs), the test suite has 2 remaining minor
failures (TestRFFT*.test_non_ndarray_with_dtype in fftpack test code) on PyPy3, which are due to
https://bitbucket.org/pypy/pypy/issues/2760