FIX: Fix int check #8608
Merged
FIX: Fix int check #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed. 1.1.0 shouldn't be too far off though. Let me go propose a schedule for that. |
rgommers
added
scipy.linalg
maintenance
|
Weird issue, but with multiple people running into it I guess it falls in the "Windows is wrong, but let's just accept it" category. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows systems sometimes
c long longints are produced, so the int check indecomp.pywas failing (see mne-tools/mne-python#4843). This generalizes the check, with included failing test.Ideally this would be backported to 1.0.1 but I think that the window on that is closed.