Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: fix failing linalg.qz float32 test by decreasing precision. #8615

Merged
merged 1 commit into from
Mar 26, 2018
Merged

TST: fix failing linalg.qz float32 test by decreasing precision. #8615

merged 1 commit into from
Mar 26, 2018

Conversation

rgommers
Copy link
Member

For float32 the default precision of decimal=6 was too high for my
machine, decimal=5 seems reasonable.

This was with MKL 2018.01, Python 3.6, NumPy and MKL installed via
Conda.

@rgommers
TST: fix failing linalg.qz float32 test by decreasing precision.
d03cf2a 
For float32 the default precision of `decimal=6` was too high for my
machine, `decimal=5` seems reasonable.

This was with MKL 2018.01, Python 3.6, NumPy and MKL installed via
Conda.
@rgommers rgommers added scipy.linalg maintenance Items related to regular maintenance tasks labels Mar 26, 2018
@rgommers rgommers added this to the 1.1.0 milestone Mar 26, 2018
tylerjereddy
tylerjereddy approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ok if all the CI passes -- 5 does seem rather low though -- I thought the IEEE standard for single precision was around 7, but these issues do seem to crop up from time to time for larger projects it seems.

@rgommers
Copy link
Member Author

Not really surprising that decimal=6 isn't always enough I think. np.finfo('float32').eps is only 1.1e-7, and there's multiple linalg operations going on here. There's other tests for float32 in linalg that have decimal=5 or even 4.

@larsoner larsoner merged commit 90d8d0d into scipy:master Mar 26, 2018
@larsoner
Copy link
Member

Agreed we're okay here, thanks @rgommers

@rgommers rgommers deleted the fix-qz-failure branch March 26, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgommers @larsoner @tylerjereddy