TST: sparse: skip test_inplace_dense for numpy<1.13 #8647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpy versions < 1.13 don't respect __array_priority__ for inplace operations, so the test does not pass. Before removal of spmatrix.__numpy_ufunc__ in 5bb3190, the test passed also on numpy < 1.13. However, numpy_ufunc is no longer present in new Numpy versions. Supporting (ndarray += sparse) for the old-numpy & new-scipy version combination is not very important, so we just skip the test in this case.
larsoner
approved these changes
Apr 2, 2018
|
Looks good, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy versions < 1.13 don't respect
__array_priority__for inplaceoperations, so the test does not pass.
Before removal of
spmatrix.__numpy_ufunc__in 5bb3190, thetest passed also on numpy < 1.13. However, numpy_ufunc is no longer
present in new Numpy versions.
Supporting (ndarray += sparse) for the old-numpy & new-scipy version
combination is not very important, so we just skip the test in this
case.
Closes gh-8604