CI: run tests with pypy3 on circleci #8783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
force-pushed
the
circleci-pypy
branch
11 times, most recently
from
6973f95
to
e73785e
Compare
pv
changed the title
pv
force-pushed
the
circleci-pypy
branch
3 times, most recently
from
891165a
to
72f3e12
Compare
pv
force-pushed
the
circleci-pypy
branch
2 times, most recently
from
4f77aa4
to
a018c1b
Compare
tylerjereddy
approved these changes
Apr 30, 2018
|
Just curious what is the reason to use CircleCI instead of Travis here? Because there is a CircleCI pypy image? To keep Travis times from increasing further? 26 minutes seems fine. +1 for merge from me |
|
The reason is that I initially expected it to be too close to Travis
time limits, and I happened to have an example circleci pypy config at
hand from which to copypaste. However, using "standard" docker image
(https://hub.docker.com/r/library/pypy/) indeed is probably easier on
circleci, and it's probably faster like this since it runs in parallel
with travis.
|
larsoner
approved these changes
Apr 30, 2018
|
I'll make a note to merge on Friday if there are no objections to the CI expansion here by then. |
|
Having all tests pass on pypy is great! |
|
Ok, looks like solid core dev support and no objections so in it goes. |
pv
added a commit
that referenced
this pull request
May 4, 2018
* MAINT: make parallelism in tools/cythonize.py adjustable * CI: run tests with pypy3 on circleci (cherry picked from commit bdfce64)
tylerjereddy
added
the
CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting also pypy3 as a platform probably does not take much extra effort (all tests pass for newest pypy release, with numpy master), and we can add it to CI to keep it working.