DOC: add note about isinstance for frozen rvs #8808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkern
reviewed
May 7, 2018
scipy/stats/_distn_infrastructure.py
Outdated
| @@ -1443,6 +1443,10 @@ class rv_continuous(rv_generic): | |||
| frozen RV object with the same methods but holding the given shape, | |||
| location, and scale fixed | |||
|
|
|||
| This object obeys ``isinstance(rv, type(rv))``. This is especially useful if a | |||
There was a problem hiding this comment.
Every object obeys that. I'm not sure what you are trying to get at here. If you'd like to say that rv is an instance of scipy.stats.distributions.rv_frozen rather than the distribution object that it was created from, that'd probably be more helpful.
|
Changes made. Thanks for those, this is more useful and what I was looking for. |
andyfaff
reviewed
May 7, 2018
|
Like that? |
andyfaff
reviewed
May 7, 2018
scipy/stats/_distn_infrastructure.py
Outdated
| @@ -1440,9 +1440,9 @@ class rv_continuous(rv_generic): | |||
| location, and scale parameters returning a "frozen" continuous RV object: | |||
|
|
|||
| rv = generic(<shape(s)>, loc=0, scale=1) | |||
| frozen RV object with the same methods but holding the given shape, | |||
| stats.distributions.rv_frozen object with the same methods but holding the given shape, | |||
There was a problem hiding this comment.
Better, I was thinking of:
`rv_frozen` object with
I think the class name needs to go in backticks.
There was a problem hiding this comment.
I think you're right.
At line 1316 there's
`rv_continuous` is a base class ...
In HTML we see
rv_continuous is a base class ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #8807