Fix (some) non-tuple index warnings #8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Jun 17, 2018
eric-wieser
reviewed
Jun 17, 2018
| @@ -2546,7 +2546,7 @@ def __init__(self, shape): | |||
| self._v = np.arange(np.prod(shape)).reshape(shape) | |||
|
|
|||
| def __getitem__(self, idx): | |||
| return self._v[idx] | |||
| return self._v[tuple(idx)] | |||
There was a problem hiding this comment.
Might make more sense to let the error propagate here, and fix it at the caller instead
There was a problem hiding this comment.
Actually, I failed to trigger this warning with the numpy HEAD, so I've just reverted this change.
eric-wieser
reviewed
Jun 17, 2018
scipy/signal/signaltools.py
Outdated
| @@ -488,7 +488,7 @@ def _reverse_and_conj(x): | |||
| Reverse array `x` in all dimensions and perform the complex conjugate | |||
| """ | |||
| reverse = [slice(None, None, -1)] * x.ndim | |||
There was a problem hiding this comment.
Could just change this one to a tuple literal rather than a list
ev-br
force-pushed
the
non_tuple_warnings
branch
from
704a7c5
to
89e0c5b
Compare
eric-wieser
approved these changes
Jun 19, 2018
|
Thanks @ev-br |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a companion to gh-8879, fix the non-tuple index warnings in
signal,interpolateandstats.