BUG: Do not catch and silence KeyboardInterrupt

[eric-wieser]

Bare excepts are only correct when trying to capture and forward exceptions - in all other cases, except Exception should be used to avoid catching KeyboardInterrupt

This only touches the code that is user-facing, not any of the tooling or tests

[tylerjereddy]

Looks sensible at first glance. I restarted the stalled linux build. Mac OS failure unrelated.

I think I've also seen this done as:

    except KeyboardInterrupt:
        raise
    except:

[larsoner]

 except KeyboardInterrupt:
        raise
    except:

IIRC this will also catch SystemExit, which is most often probably not what is desired.

[eric-wieser]

I assume the test failure is unrelated?

[larsoner]

Now that this is in, I think there is some style checker we can reconfigure to ensure we don't get new ones. I'll look into it unless someone else beats me to it. Should be a simple change.

[eric-wieser]

@larsoner: Maybe, although I left all the ones alone in the tests