MAINT: removed unused import sys #9301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests all pass, merging. Thanks @Gotham13121997 |
|
Hey @ev-br I found couple more unused imports. Should I create individual pull requests or remove them all in one?? |
|
Maybe lump them together |
|
Yeah i thought so but there are around 160 instances. I think I will go
about them module wise. It will be better.
…On Sun, 23 Sep 2018, 01:01 Evgeni Burovski, ***@***.***> wrote:
Maybe lump them together
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9301 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZNjHAak44mWMGzAIhePYtKIyPjLK3Qtks5udpAPgaJpZM4W1UAs>
.
|
Just try and group them a little please. We have ~15 modules; 15 PRs on this kind of cleanup is a bit much. |
|
sure
…On Sun, 23 Sep 2018, 08:10 Ralf Gommers, ***@***.***> wrote:
Yeah i thought so but there are around 160 instances. I think I will go
about them module wise. It will be better.
Just try and group them a little please. We have ~15 modules; 15 PRs on
this kind of cleanup is a bit much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9301 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AZNjHFqzjAaBd3j_YwhlhtNcn5M6ttPSks5udvSQgaJpZM4W1UAs>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys module was imported but not used in
scipy/scipy/sparse/linalg/eigen/lobpcg/lobpcg.py
Line 15 in 74f4e5a