MAINT: TST: Make tests NumPy 1.8 compatible #9379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilayn
added
scipy.optimize
scipy.signal
maintenance
ilayn
changed the title
|
squashing and merging this since all PRs are failing on this and the change is clear enough to track what changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9190 and #8259 , the tests involve the usage of
np.moveaxisandnp.testing.assert_warnswhich are introduced in NumPy 1.11 but we still support 1.8.And for some reason it has not failed in the original PRs but started to fail recently. I have converted to 1.8.2 compatible syntax without changing the logic.