Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: linalg: Shorter ill-conditioned warning message #9408

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

pv
Copy link
Member

@pv pv commented Oct 27, 2018

Make the ill-conditioned matrix warning one-liner. Fix the missing
space between the number and text.

Previously, the warning read

__main__:1: LinAlgWarning: scipy.linalg.solve
Ill-conditioned matrix detected. Result is not guaranteed to be accurate.
Reciprocal condition number1.000000e-19

Some issues that are addressed here: there's no space before condition number, the message is quite long, usually the warnings don't contain the function name, and usually they don't contain newlines.

@ilayn
Copy link
Member

ilayn commented Oct 27, 2018

Recip.number reads a bit odd, rcond might be better if we are going for an abbreviation. It is familiar enough from matlab. One of the tests is looking for an exact old phrase though.

@ilayn ilayn added enhancement A new feature or improvement scipy.linalg labels Oct 27, 2018
@ilayn ilayn added this to the 1.2.0 milestone Oct 27, 2018
Make the ill-conditioned matrix warning one-liner.  Fix the missing
space between the number and text.
@pv
Copy link
Member Author

pv commented Oct 27, 2018

Ok, changed to rcond instead as it's shorter.
Initially I wanted to say "condition number" somewhere, but "ill-conditioned matrix" seems easily googleable.

@ilayn ilayn merged commit 551037c into scipy:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants