Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: try fixing a collection error under pytest 8.1.x #143

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Mar 4, 2024

closes gh-142 if successful

@ev-br
Copy link
Member Author

ev-br commented Mar 4, 2024

The diff is messier then it is: this PR only adds a branching on pytest < 8 or not (hence next indent level for what was there), and uses a simpler version takes from pytest 8.1.0.
To make diff clearer, select settings -> hide whitespace in the review panel.

WDYT @Sheila-nk ?

@ev-br ev-br changed the title MAINT: try fixing a a collection error under pytest 8.1.x MAINT: try fixing a collection error under pytest 8.1.x Mar 4, 2024
@Sheila-nk
Copy link
Collaborator

Great job on this PR and for catching the bug introduced by pytest's new release!
The solution looks straightforward, and it's awesome to see that pytest>8 tests are passing. 🚀

@ev-br
Copy link
Member Author

ev-br commented Mar 5, 2024

pytest 8.1.0 is yanked from pypi :-). That said, the else: branch added here tracks the current pytest master, the failure was in the branch taken from pytest 7.4.x, so we're probably good for now.
Merging, thanks for the review Sheila.

@ev-br ev-br merged commit 1dd6ff4 into main Mar 5, 2024
4 checks passed
@ev-br ev-br deleted the pytest8.1 branch March 5, 2024 09:33
@Sheila-nk
Copy link
Collaborator

Got it! Thank you for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin breaks with pytest 8.1.0
2 participants