Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with NArray's NMatrix #27

Closed
kojix2 opened this issue Oct 9, 2015 · 2 comments
Closed

conflict with NArray's NMatrix #27

kojix2 opened this issue Oct 9, 2015 · 2 comments

Comments

@kojix2
Copy link
Member

kojix2 commented Oct 9, 2015

Hi @v0dro

Thank you for your great gem!
But daru conflict with Tanaka's NArray.

 Error:  /narray-0.6.1.1/nmatrix.rb:8:in `<top (required)>': uninitialized constant NArray (NameError)

daru.rb

lib_underscore = library.to_s.gsub(/-/, '\_').gsub('/', '\_')
create_has_library :'nmatrix/nmatrix'

daru/accessors/nmatrix_wrapper.rb

end if Daru.has_nmatrix_nmatrix?

This work. But not cool.

@v0dro
Copy link
Member

v0dro commented Oct 9, 2015

Hmm thanks for reporting this. I havnt quite updated the nmatrix dependency ever since nmatrix was newly updated.

We'll just need to change the require 'nmatrix' in daru to latest one that does not conflict with narray.

@v0dro
Copy link
Member

v0dro commented Nov 12, 2015

Could send a PR changing require 'nmatrix' to require 'nmatrix/nmatrix'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants