Code is sent with subject and test doesn't filter out acq files

scitran · Sep 11, 2017 · 0a651e6 · 0a651e6
1 parent 4d96321
commit 0a651e6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/api/download.py b/api/download.py
@@ -139,10 +139,12 @@ def _preflight_archivestream(self, req_spec, collection=None):
                 subject_prefixes = {}
                 for session in session_dict.itervalues():
                     if session.get('subject'):
-                        code = session['subject'].get('code', 'unknown_subject')
-                        # This is bad and we should try to combine these somehow,
-                        # or at least make sure we get all the files
-                        subject_dict[code] = session['subject']
+                        subject = session.get('subject', {'code': 'unknown_subject'})
+                        code = subject.get('code')
+                        if code is None:
+                            code = 'unknown_subject'
+                            subject['code'] = code
+                        subject_dict[code] = subject
 
                 for code, subject in subject_dict.iteritems():
                     subject_prefix = prefix + '/' + self._path_from_container(subject, used_subpaths, ids_of_paths, code)

diff --git a/test/integration_tests/python/test_download.py b/test/integration_tests/python/test_download.py
@@ -37,14 +37,10 @@ def test_download(data_builder, file_form, as_admin, api_db):
     r = as_admin.post('/download', json={
         'optional': False,
         'filters': [{'tags': {
-            '-': ['minus'],
-            '+': ['plus']
+            '-': ['minus']
         }}],
         'nodes': [
-            {'level': 'project', '_id': project},
-            {'level': 'session', '_id': session},
-            {'level': 'acquisition', '_id': acquisition},
-            {'level': 'acquisition', '_id':acquisition2},
+            {'level': 'project', '_id': project},        
         ]
     })
     assert r.ok
@@ -60,6 +56,7 @@ def test_download(data_builder, file_form, as_admin, api_db):
     # Verify a single file in tar with correct file name
     found_second_session = False 
     for tarinfo in tar:
+        print tarinfo.name
         assert os.path.basename(tarinfo.name) == file_name
         if 'session1_0' in str(tarinfo.name):
             found_second_session = True