You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to build the MUMPS library as part of a separate CMake-based project and when I do, I get -Wimplicit-function-declaration warnings which flare up as errors. To address this, I currently have a patch file that adds the C flag -Wno-implicit-function-declaration using the following code:
Would you have any problem with adding this flag in to prevent it from blocking the build of the project? I think this would be helpful for projects that pull MUMPS in using FetchControl or ExternalProject. If you'd like, I could create a PR for this.
Thanks!
Puneet
P.S. As I write this, I see that it would be more natural to append the flags with the following code:
# Append to current flags
list(APPEND CMAKE_C_FLAGS -Wno-implicit-function-declaration)
The text was updated successfully, but these errors were encountered:
puneetmatharu
changed the title
Request to add C compiler flags to silence implicit function declaration error
Request to add -Wno-implicit-function-declaration flag to silence "implicit function declaration" error
May 31, 2021
puneetmatharu
changed the title
Request to add -Wno-implicit-function-declaration flag to silence "implicit function declaration" error
Request to add "-Wno-implicit-function-declaration" flag to silence implicit function declaration error
May 31, 2021
Hi, in the commit that you closed this issue with, you added a flag to scalapack_c_flags to remove the aforementioned warning. However, it only accounts for the case that the user is using a GNU compiler. It unfortunately does not address the issue I encountered on MacOS (for which the compiler is Clang). Could you please adjust the code in cmake/scalapack.cmake to account for this? Thank you.
Hi,
I was trying to build the MUMPS library as part of a separate CMake-based project and when I do, I get
-Wimplicit-function-declaration
warnings which flare up as errors. To address this, I currently have a patch file that adds the C flag-Wno-implicit-function-declaration
using the following code:Would you have any problem with adding this flag in to prevent it from blocking the build of the project? I think this would be helpful for projects that pull MUMPS in using
FetchControl
orExternalProject
. If you'd like, I could create a PR for this.Thanks!
Puneet
P.S. As I write this, I see that it would be more natural to append the flags with the following code:
The text was updated successfully, but these errors were encountered: