Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with openblas fixes #60

Closed
wants to merge 3 commits into from

Conversation

gkaf89
Copy link
Contributor

@gkaf89 gkaf89 commented Jul 14, 2023

These are a few fixes in the compilation with OpenBLAS. The issues rectified are the following:

  1. Allow multiple directories in CMAKE_PREFIX_PATH, e.g. -D CMAKE_PREFIX_PATH:PATH="${HOME}/opt/scalapack;${HOME}/opt/openblas"
  2. Link with the correct LAPACK library wehn building with OpenBLAS. OpenBLAS links BLAS and LAPACK in a single shared object, libopenblas.so. The reference implementation of Netlib is used, with some parts optimized.
  3. Report support for GEMMT by initializing the flag BLAS_HAVE_GEMMT.

@scivision scivision force-pushed the main branch 2 times, most recently from 4c8d71f to f22f256 Compare July 14, 2023 14:06
@scivision
Copy link
Owner

scivision commented Jul 14, 2023

Thanks I used two of your commits, but implemented OpenBLAS in a more general way.
ad06d43
5a7fd7e

I also added a CI test for OpenBLAS https://github.com/scivision/mumps/actions/runs/5555844546/jobs/10147547056.

To specify OpenBLAS:

cmake -Bbuild -DLAPACK_VENDOR=OpenBLAS

# optional if having trouble auto-finding OpenBLAS
cmake -Bbuild -DLAPACK_VENDOR=OpenBLAS -DLAPACK_ROOT=/path/to/openblas

@scivision scivision closed this Jul 14, 2023
@gkaf89
Copy link
Contributor Author

gkaf89 commented Jul 15, 2023

Thank you for the quick merge!

Don't worry about modifying my approach, I am new in the code base and thus still a bit reluctant to make extended refactorings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants