Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

memtests failing? #57

Closed
tdhock opened this issue May 4, 2020 · 9 comments
Closed

memtests failing? #57

tdhock opened this issue May 4, 2020 · 9 comments

Comments

@tdhock
Copy link

tdhock commented May 4, 2020

hi @sckott can we query your db to get a list of all packages for which at least one of the memtests https://www.stats.ox.ac.uk/pub/bdr/memtests/README.txt fails?

@sckott
Copy link
Owner

sckott commented May 4, 2020

hi, can you show me an example of a cran check that has these failures?

@tdhock
Copy link
Author

tdhock commented May 4, 2020

https://cloud.r-project.org/web/checks/check_results_BuyseTest.html
https://cloud.r-project.org/web/checks/check_results_cld2.html
some more on current CRAN:

> unique(type.dt$pkg)
 [1] "AGread"              "bigmemory"           "BuyseTest"          
 [4] "cld2"                "cld3"                "compboost"          
 [7] "dggridR"             "DStree"              "fastAdaboost"       
[10] "FLSSS"               "FRegSigCom"          "glamlasso"          
[13] "glmmsr"              "GMKMcharlie"         "GreedySBTM"         
[16] "iptools"             "isotree"             "kernelboot"         
[19] "later"               "lda.svi"             "milr"               
[22] "mined"               "mixggm"              "OneArmPhaseTwoStudy"
[25] "pdftools"            "PP"                  "PRIMME"             
[28] "protolite"           "pts2polys"           "r2sundials"         
[31] "RcppDE"              "Rdimtools"           "Rdtq"               
[34] "RMKL"                "rTRNG"               "sboost"             
[37] "Scalelink"           "scPDSI"              "scrypt"             
[40] "TDA"                 "tesseract"           "TreeLS"             
[43] "volesti"            
> 

@tdhock
Copy link
Author

tdhock commented May 4, 2020

(I downloaded the check pages myself)

@sckott
Copy link
Owner

sckott commented May 4, 2020

the API does collect additional issues - e.g., https://cranchecks.info/pkgs/BuyseTest - so you can look in that array for each packages data.

there is no search for this API though, so you'd have to pull down data for all pkgs and then search across the additional issues. we've been considering adding search but just haven't had enough strong use cases yet

note that there's historical data up on Amazon S3 https://github.com/ropenscilabs/cchecksapi/blob/master/docs/api_docs.md#history - each day of checks data is zipped up as newline delimited JSON as a single file - you can just pull those filesl down and read in with jsonlite::stream_in i think

also note that we don't collect the text of the individual platform page checks for each package. we only have what's on the package level html page - been thinking about scraping the other pages linked to so that we have all data but just haven't had time to do that

@tdhock
Copy link
Author

tdhock commented May 5, 2020 via email

@sckott
Copy link
Owner

sckott commented May 5, 2020

anything else?

@tdhock
Copy link
Author

tdhock commented May 5, 2020

it would be more user-friendly to have a search API endpoint, so then I would only have to make one request to make my query (rather than N requests where N is the number of packages, and so it is basically the same complexity as downloading the raw CRAN check pages). so maybe you want to keep this issue open for that, but otherwise it is fine with me to close.

@sckott
Copy link
Owner

sckott commented May 5, 2020

i agree that search would be most user friendly. it does require more work as you'd imagine. i'll have a look and see if we can do this easily

sckott added a commit that referenced this issue May 13, 2020
- /search route searches in histories table - so doesnt include newest data in mongodb
- data searched would be up to ~24 hrs old but could just be 1 hr old e.g.
- added new Search activerecord class to handle /search route requests
- added minimal /search  info to docs
@sckott
Copy link
Owner

sckott commented May 13, 2020

@tdhock just pushed change to the API, now has a /search route. it searches the historical data. the newest data is pushed into history table once a day, so history only lacks the very newest data. this is a fulltext search of ONLY the check_details field for each package for each day. docs at https://github.com/ropenscilabs/cchecksapi/blob/notifications/docs/api_docs.md#search

search for "memory"

https://cranchecks.info/search?q=memory

one_each - so you can get one result per package

https://cranchecks.info/search?q=memory&one_each=true

limit fields returned, date_updated always returned

https://cranchecks.info/search?q=memory&one_each=true&fields=package


@maelle ^ search added.

@sckott sckott closed this as completed May 13, 2020
sckott added a commit that referenced this issue May 13, 2020
- /search route searches in histories table - so doesnt include newest data in mongodb
- data searched would be up to ~24 hrs old but could just be 1 hr old e.g.
- added new Search activerecord class to handle /search route requests
- added minimal /search  info to docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants