Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #48

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Patch 2 #48

merged 2 commits into from
Aug 4, 2019

Conversation

joey741019
Copy link
Contributor

Hotfix of PHP variables add space for sed correct replace and add change log

@jflemer-ndp
Copy link

It would be more robust to handle arbitrary space, including none with "<space>*". For example:

s/^\(memory_limit *=\).*/\1 ${PHP_MEMORY_LIMIT}/

@scline
Copy link
Owner

scline commented Aug 4, 2019

Thank you for contributing back @joey741019, apologize for the delay. Great advice @jflemer-ndp, if no one PR's that addition I will throw it in (^_^)

@scline scline merged commit 4410593 into scline:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants