Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action for Python-tests #8

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Conversation

phracek
Copy link
Member

@phracek phracek commented Jul 27, 2022

Signed-off-by: Petr "Stone" Hracek phracek@redhat.com

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@frenzymadness
Copy link
Member

After a brief investigation of what happened in the CI, it seems that you should use from flexmock import flexmock instead of just import flexmock in test_api.py, see https://github.com/flexmock/flexmock/blob/master/CHANGELOG.md#changed-1

I'm gonna do a full review later.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Co-authored-by: Lumír 'Frenzy' Balhar <frenzy.madness@gmail.com>
tox.ini Show resolved Hide resolved
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Copy link
Member

@frenzymadness frenzymadness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Although why don't you remove all the old stuff for testing the same code in the container like Makefile, Dockerfile etc.?

@phracek phracek merged commit 86a8795 into master Jul 28, 2022
@phracek phracek deleted the testing_in_several_python_version branch May 9, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants