Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize tests #27

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Centralize tests #27

merged 2 commits into from
Sep 14, 2017

Conversation

praiskup
Copy link
Contributor

No description provided.

@praiskup
Copy link
Contributor Author

@omron93, looks like there's some bug in the script; the CI reports "no space left on device". Can you debug?

@praiskup
Copy link
Contributor Author

[test] let's try again, Jenkins :), before we hack you ...

@praiskup praiskup force-pushed the centralize-tests branch 2 times, most recently from 68bb0e4 to 9595764 Compare August 31, 2017 08:27
@praiskup
Copy link
Contributor Author

[test]

@pkubatrh
Copy link
Member

It seems like the Required-by commit message does not start the tests for mongodb (I can only see runs for postgresql and python in the CI). Possibly related:

10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch
10:05:57 fatal: unrecognized argument: --no-patch

@hhorak
Copy link
Member

hhorak commented Sep 11, 2017

@praiskup It looks like tests are green, anything else is missing? It looks very nice to me..

@pkubatrh
Copy link
Member

@hhorak @praiskup I do not think the issue with --no-patch has been resolved yet. Given that (afaik) we want to test this PR against mongodb-container#258 we should first make sure the tests are run as expected.

@praiskup
Copy link
Contributor Author

praiskup commented Sep 11, 2017

Right, I tried to solve this via #31.

@hhorak
Copy link
Member

hhorak commented Sep 11, 2017

Weird, I'd expect centos7 and rhel7 to have the same version of git..

@praiskup
Copy link
Contributor Author

Sorry, that's wrongly named ticket; the issue is on both centos7/rhel7. By RHEL7 I meant any el7 "fork".

@praiskup
Copy link
Contributor Author

Ok, I squashed Tomas's commits into one; and fixed the testsuite (commit nr. 1). The CI seems to pass, so should we merge and continue with the development later? @omron93, @pkubatrh, @hhorak ?

@praiskup
Copy link
Contributor Author

Ping, can we merge?

@omron93
Copy link
Contributor

omron93 commented Sep 14, 2017

+1 for merging. This look really good. Thanks.

@pkubatrh
Copy link
Member

lgtm, tests are passing against mongodb now, so merging. Thanks!

@pkubatrh pkubatrh merged commit 97e8fce into sclorg:master Sep 14, 2017
@praiskup praiskup deleted the centralize-tests branch March 28, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants