Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naive incremental build tests #2

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Add naive incremental build tests #2

merged 1 commit into from
Dec 19, 2017

Conversation

jcajka
Copy link
Contributor

@jcajka jcajka commented Dec 7, 2017

Add the incremental build tests as promised.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@omron93
Copy link

omron93 commented Dec 8, 2017

[test]

@omron93
Copy link

omron93 commented Dec 8, 2017

I've tried on my laptop and sometimes incremental build failed (import-with-vendor-app)

$ IMAGE_NAME=centos/go-toolset-7-centos7 ./s2i-build-incremental 
I1208 15:24:19.289119 22568 clone.go:32] Downloading "/home/mskalick/Packages/docker/sclorg/golang-container/1.8/test/import-with-vendor-app/app" ...
I1208 15:24:19.315601 22568 install.go:251] Using "assemble" installed from "image:///usr/libexec/s2i/assemble"
I1208 15:24:19.315642 22568 install.go:251] Using "run" installed from "image:///usr/libexec/s2i/run"
I1208 15:24:19.315662 22568 install.go:251] Using "save-artifacts" installed from "image:///usr/libexec/s2i/save-artifacts"
E1208 15:24:20.652695 22568 tar.go:321] Error extracting file "pkg/linux_amd64/github.com/cpuguy83/go-md2man/md2man.a": unexpected EOF
E1208 15:24:20.652731 22568 tar.go:333] Error extracting tar stream
W1208 15:24:21.632528 22568 sti.go:160] Clean build will be performed because of error saving previous build artifacts
/tmp/src ~
~

But this is random and not often :-(

@jcajka Do you have any idea what could cause this?

@omron93
Copy link

omron93 commented Dec 8, 2017

[test]

@hhorak
Copy link
Member

hhorak commented Dec 19, 2017

It works ok repeatadly on my machine.. LGTM

@hhorak hhorak merged commit 9664ec5 into sclorg:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants