Centos based image-stream for usage in OpenShift #4
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@bparees fyi |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@hhorak I wasn't sure naming convention for these repos but I figured this could just be a start. I can update library and pull it into OSO starter as well. Just let me know. |
|
@jcajka I updated the structure to match https://github.com/sclorg/s2i-ruby-container/tree/master/imagestreams and switched the sample to use a dedicated separate repo for the example. Will evolve the example as needed and move to sclorg (or someone can create better example) |
|
Just a side note: having some standartized locations for template and imagestream files would be really nice (I do have some automation regarding that and intend to have more). |
|
@pvalena has there been any progress on setting some standard for streamfiles (location)? |
|
@jcajka the current location is fine. |
imagestreams/golang-centos7.json
Outdated
| "kind": "ImageStreamTag", | ||
| "name": "1.8" | ||
| }, | ||
| "name": "latest" |
There was a problem hiding this comment.
imagestreams/golang-centos7.json
Outdated
| "kind": "DockerImage", | ||
| "name": "docker.io/centos/go-toolset-7-centos7:latest" | ||
| }, | ||
| "name": "1.8" |
|
I've not tested it (esp. the example), and there're no tests. Could you provide sample of logs for 3.9? Otherwise it LGTM. |
|
@pvalena I think I've made all needed changes and is ready to merge, let me know if you need anything else |
imagestreams/golang-centos7.json
Outdated
| "iconClass": "icon-go-gopher", | ||
| "openshift.io/display-name": "Go (Latest)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/sspeiche/golang-ex.git", |
There was a problem hiding this comment.
Would it be possible to move sample app into https://github.com/sclorg/ org?
There was a problem hiding this comment.
at a minimum it should be https://github.com/openshift/golang-ex
but yeah, i can go ahead and move the repo. That said, it's a weird sample because it doesn't rely on the s2i-golang image:
https://github.com/openshift/golang-ex/blob/master/Dockerfile
So i dunno that the SCL team wants to own it?
We probably need to create a new golang sample that actually does use the golang s2i builder:
https://github.com/sclorg/golang-container
There was a problem hiding this comment.
@pvalena i created https://github.com/sclorg/golang-ex
feel free to update the settings/collaborators on the repo to whatever you guys want them to be.
imagestreams/golang-centos7.json
Outdated
| "iconClass": "icon-go-gopher", | ||
| "openshift.io/display-name": "Go (1.8)", | ||
| "openshift.io/provider-display-name": "Red Hat, Inc.", | ||
| "sampleRepo": "https://github.com/openshift/origin.git", |
There was a problem hiding this comment.
I'm not sure about this one... Shouldn't it be the same url as above?
|
before we proceed with this, we should fix the sample so that it is built using the s2i builder, not embedding its own Dockerfile. |
|
Moved my sample to https//github.com/sclorg/golang-ex.git and updated references to it from this image-stream (in both locations). /ptal @pvalena |
@bparees, I somehow missed this, would you mind to elaborate? Do you mean the sample app? The |
I don't think the sclorg one existed before now. We just created it here: but yes, it now uses s2i. |
|
@pvalena looks like this is ready to merge, not outstanding comments |
|
Although I've not tested this, it LGTM. |
No description provided.