Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add template icon #152

Merged
merged 1 commit into from
Feb 1, 2022
Merged

add template icon #152

merged 1 commit into from
Feb 1, 2022

Conversation

alfonsoalongi
Copy link
Contributor

add template icon

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@phracek
Copy link
Member

phracek commented Dec 15, 2021

@alfonsoalongi Thanks for this pull request. The pull request looks good to me.

@yselkowitz Does it work? Please let me know.

@alfonsoalongi
Copy link
Contributor Author

@alfonsoalongi Thanks for this pull request. The pull request looks good to me.

@yselkowitz Does it work? Please let me know.

Hi,
yes it works. I checked it on OpenShift Container Platform 4.7 but not on OKD. I attached a screenshot about the graphical result.
mariadb-icon

@yselkowitz
Copy link
Contributor

Didn't have a chance to try it yet, but it's just a label, so why not. We should look at the rest of the templates and try (testing and) adding similar flags.

@alfonsoalongi
Copy link
Contributor Author

I think so too. Yes, I also tried similar annotations with the other database templates.
For MySQL: sclorg/mysql-container#300
For PostgreSQL: sclorg/postgresql-container#409
I can also check other icons for other templates but feedbacks to pull requests on github repositories come too late. This pull request dates back to May 25 (almost 7 months ago).

@yselkowitz
Copy link
Contributor

LGTM

@phracek
Copy link
Member

phracek commented Jan 11, 2022

[test-all]

@phracek phracek merged commit 0223041 into sclorg:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants