Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding galera packages and exposing ports #67

Closed
wants to merge 1 commit into from

Conversation

jcpowermac
Copy link

This PR adds the necessary package and exposes the ports required to run Galera.

Resolves #65

Testing was done in this repository:
https://github.com/jcpowermac/mariadb-ha-poc/blob/master/Dockerfile

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

3 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@omron93
Copy link
Contributor

omron93 commented Feb 5, 2018

Why which package is installed explicitly?

[test] [test-openshift]

@jcpowermac
Copy link
Author

@omron93 I was testing with this earlier maybe it was left over. I don't need it let me remove it. I did this PR to get a feel if its going to be accepted. I can update the other Dockerfiles as well.

@jcpowermac
Copy link
Author

@omron93 I am wrong we need which...

/opt/rh/rh-mariadb102/root/usr//bin/wsrep_sst_common: line 120: which: command not found

This PR adds the necessary package and exposes the ports required to run
Galera.

Testing was done in this repository:
https://github.com/jcpowermac/mariadb-ha-poc/blob/master/Dockerfile
@hhorak
Copy link
Member

hhorak commented Feb 6, 2018

I'm fine with doing these changes as a first step for having the galera replication ready, although I imagine that there should also be something more in the future -- scripts that would set up galera replication similarly to the master/slave replication and the only thing a user would need to do would be setting 'MYSQL_CLUSTER_NODES' (done probably automatically in k8s environment). I've already worked on this a bit previously, but did not really made it a good enough for even a PR:
hhorak@ae8ca15

Anyway, there is also a package rh-mariadb102-mariadb-server-galera, that ships few tools (clustercheck, galera_recovery) and galera.cnf. However, the galera.cnf enables wsrep features once installed, so it could influenced the use cases where wsrep is not ready, so I agree with this variant of PR, that does not installs rh-mariadb102-mariadb-server-galera.

That said, @jcpowermac, do you already have some experiences locally with using this mariadb image together with the galera?

@hhorak
Copy link
Member

hhorak commented Feb 6, 2018

[test]
[test-openshift]

@jcpowermac
Copy link
Author

@hhorak hmm the tools though might be useful right? So my use case is purely openshift/kube. My scripts are here: https://github.com/jcpowermac/mariadb-ha-poc
Under image-customization. There are incrediably simple and probably wouldn't be any use to this project. What was wrong with yours? Maybe it makes sense to move forward with your branch instead?

@tchughesiv
Copy link

imho the branches don't appear to be conflicting... any reason both use-cases couldn't be supported?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jcpowermac
Copy link
Author

@hhorak what can we do to get this PR moving?

@rhscl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jcpowermac jcpowermac closed this Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants