get names consistent; associated doc updates based on test walkthrough #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ One option is to use the Docker all-in-one launch as described in the [OpenShift | |||
|
|
|||
| ### The project ### | |||
|
|
|||
| If you don't have a project setup all ready, go ahead and take care of that | |||
| After logging in (`oc login`, when any ID/Password combination should be fine), if you don't have a project setup all ready, go ahead and take care of that | |||
There was a problem hiding this comment.
s/when/with/ but more importantly any combination is only fine for the dev openshift environments we run, the one they're using will hopefully be more locked down. so i'd just say to login with oc login.
There was a problem hiding this comment.
change done ... will merge/commit/squash in the AM
|
@bparees comments etc. incorporated for nodejs-ex |
|
|
||
| Note, you can follow along with the web console (located at https://ip-address:8443/console) to see what new resources have been created and watch the progress of the build and deployment. | ||
|
|
||
| #### build #### | ||
|
|
||
| $ oc start-build nodejs --follow | ||
| If the build is not started (you can check by running "oc get builds"), start one and stream the logs with:: |
|
one more nit and then it looks good. |
…h; Ben's comments; minor fixes / frontend rename; fix double colon
|
nit fixed - thx |
|
lgtm. |
bparees
added a commit
that referenced
this pull request
Jul 1, 2015
get names consistent; associated doc updates based on test walkthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bparees nodejs-ex changes for issue3358