Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-forward the 'common' sub-project #237

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Conversation

praiskup
Copy link
Contributor

This is to fix build-system regression
sclorg/container-common-scripts#60

@pkubatrh
Copy link
Member

[test-openshift]

@praiskup
Copy link
Contributor Author

@omron93
Copy link
Contributor

omron93 commented Feb 14, 2018

two different issues in both CIs?

Both connected to getting IP of slave. oc versions are different in RHEL (oc v3.6.173.0.83) and CentOS (oc v3.7.0+7ed6862), so this could cause the difference in the output.

@pkubatrh
Copy link
Member

Seems like the first failures that got squashed were introduced in #233

@praiskup
Copy link
Contributor Author

[test-openshift]

@praiskup
Copy link
Contributor Author

I've added some description for the test fix, [test-openshift]

@praiskup
Copy link
Contributor Author

@praiskup
Copy link
Contributor Author

[test-openshift]

praiskup added a commit to praiskup/container-common-scripts that referenced this pull request Feb 15, 2018
@praiskup
Copy link
Contributor Author

omron93 pushed a commit to sclorg/container-common-scripts that referenced this pull request Feb 15, 2018
After successful pod scale to 2, it takes some time to have the
replica ready, and it probably takes some time to get allocated
the IP address.  So rather wait for the pod to be ready before we
expect that the IP is available.

We could in future make the 'ct_os_get_pod_ip' accept some option
which would wait till the IP is available.
@praiskup
Copy link
Contributor Author

[test-openshift]

@praiskup
Copy link
Contributor Author

PTAL, should be ready.

@praiskup
Copy link
Contributor Author

[test-openshift] last time, now with 4GB of ram

@omron93
Copy link
Contributor

omron93 commented Feb 15, 2018

LGTM. Small changes...

@praiskup Thanks.

@omron93 omron93 merged commit 7578ec7 into sclorg:master Feb 15, 2018
@praiskup praiskup deleted the bs-regression branch March 28, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants