Do not ignore SQL failures and check that we still work with previous data when changing password #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
hhorak
force-pushed
the
fix-interactive-psql
branch
from
1d3c8f7
to
0d04f71
Compare
hhorak
changed the title
… data when changing password Fix also postgresql_cmd function that should not ignore SQL errors (thus using ON_ERROR_STOP option now) and was often called with an interactive input using <<< but podman run is run in non-interactive mode, resulting in the SQL commands to not be printed, so checking them later did not work and errors are not visible. Using -c option solves this. Function test_postgresql was called with a parameter that was not used anywhere. This function used CREATE EXTENSION to test proper PostgreSQL functionality, that only admin have permissions for. So, the parameter of test_postgresql function was changed to have a useful meaning. The meaning is that only if the parameter is "admin", the CREATE EXTENSION statement is run to not see "Not enough permissions" error when the contianer is run as a normal user.
hhorak
force-pushed
the
fix-interactive-psql
branch
from
0d04f71
to
d596dbc
Compare
|
[test] |
This was referenced Jan 5, 2024
zmiklank
approved these changes
Jan 9, 2024
I'd rather leave it flexible, so the caller of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix also postgresql_cmd function that should not ignore SQL errors (thus using ON_ERROR_STOP option now) and was often called with an interactive input using <<< but podman run is run in non-interactive mode, resulting in the SQL commands to not be printed, so checking them later did not work and errors are not visible. Using
-coption solves this.Function test_postgresql was called with a parameter that was not used anywhere. This function used
CREATE EXTENSIONto test proper PostgreSQL functionality, that only admin have permissions for.So, the parameter of test_postgresql function was changed to have a useful meaning. The meaning is that only if the parameter is "admin", the
CREATE EXTENSIONstatement is run to not see"Not enough permissions" error when the contianer is run as a normal user.