Log httpd log_error to stderr

[ppisar]

This patch set fixes issue #72.

[mfojtik]

LGTM

[rhcarvalho]

@ppisar nice patch 👏 ! Thanks! :)

@mfojtik the original issue was left open. BTW we need this for PHP and perhaps other httpd-based images as well...

[rhcarvalho]

Minor nit: s/countainer/container

[rhcarvalho]

Well, too late, but worth asking: could we get the tests for both image versions? (5.16 is missing)

[ppisar]

On Wed, Mar 02, 2016 at 02:51:41PM -0800, Rodolfo Carvalho wrote:

Well, too late, but worth asking: could we get the tests for both image
versions? (5.16 is missing)

The 5.20 has different test "frame work". 5.16 tests are not extendable.

Actually the tests should be rewritten to something more suitable for testing
that supports nesting subtests, reporting failure reason, parallel testing
etc. E.g. Perl's Test::More. But I don't know if that were acceptable for
OpenShift. I've never seen what OpenShift test environment provides,
guarantees or expects.

-- Petr

[rhcarvalho]

Actually the tests should be rewritten to something more suitable for testing
that supports nesting subtests, reporting failure reason, parallel testing
etc.

I totally agree 👍

The tests in this repository are OpenShift-agnostic, they require just docker.

However, we need to take a more holistic view when talking about a change like rewriting.
Historically, they started as a "common" "framework" that is generated by s2i create. That command creates a scaffolding for creating new S2I builder images.

Through the past year, when working on the builder images and trying to improve the tests, I was reminded to keep the consistency among the images we provide, which is good in one hand, but hard to maintain over time. And as you just pointed out, Perl tests for 5.16 and 5.20 went out of sync...

(and there is really another problem in there, copy-paste...)

IMHO Bash is great for short scripts, but is a very poor tool for writing the day-after-day more complex scripts that empower the images, and very poor for writing tests.

Even though Perl's Test::More is very cool, I doubt we have enough Perl know-how across the team to make it the "new language" for the scripts in all images.

Given what's in the base OS image, I'd say our choices are Bash, Perl, Python.

[mfojtik]

@rhcarvalho the tests also depend on s2i binary.

[mfojtik]

@rhcarvalho also as you said, few of us have confidence in perl or python or ruby to start writing tests for images. We do all do Go, but that leaves SCL folks out of loop because that is something they don't do. So even it sound silly, the "bash" is the only common framework we share currently :-) And I'm OK improving it or making the testing framework better.