Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PHP S2I Opcache configuration #151

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Conversation

lucasnetau
Copy link
Contributor

Fixes #150 and #149

@rhscl-bot
Copy link

Can one of the admins verify this patch?

1 similar comment
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@andrewklau
Copy link
Contributor

@hhorak @bparees fyi

@caruccio
Copy link

+1

@bparees
Copy link
Collaborator

bparees commented Mar 15, 2017

lgtm, thanks @lucasnetau

@omron93
Copy link
Contributor

omron93 commented Mar 16, 2017

Please run tests, before merging. Tests are failing for 7.0, so image is not built.

Fatal Error Zend OPcache cannot allocate buffer for interned strings

@lucasnetau @bparees @andrewklau @remicollet How to fix it?

@remicollet
Copy link
Contributor

opcache.memory_consumption is obviously to small

$ php -d opcache.enable_cli=1 -d opcache.memory_consumption=16 -d opcache.interned_strings_buffer=8 -v
Thu Mar 16 11:08:39 2017 (20578): Fatal Error Zend OPcache cannot allocate buffer for interned strings

$ php -d opcache.enable_cli=1 -d opcache.memory_consumption=24 -d opcache.interned_strings_buffer=8 -v
PHP 7.0.17 (cli) (built: Mar 14 2017 14:39:53) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.0.17, Copyright (c) 1999-2017, by Zend Technologies

@lucasnetau
Copy link
Contributor Author

@omron93 Please see #152 which explains the issue. This patch corrected the installation of the opcache profile, I left the defaults as set in the original file.

Unfortunately in all my environments I have OPCACHE_MEMORY_CONSUMPTION to values greater than 16 so did not pick up on the issue until after the pull request was merged.

Setting OPCACHE_MEMORY_CONSUMPTION=18 or higher will allow the container to run. I've posed a question to the maintainers as to what a sensible default should be.

@omron93
Copy link
Contributor

omron93 commented Mar 16, 2017

@lucasnetau @remicollet Thanks for help and quick fix.

@bparees
Copy link
Collaborator

bparees commented Mar 16, 2017

@remicollet sorry, I saw green and thought it meant the tests had run, didn't notice that the bot was asking for admin approval before running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants