-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected pkgs libjpeg-turbo libjpeg-turbo-devel #102
Conversation
Added the correct packages libjpeg-turbo libjpeg-turbo-devel
Can one of the admins verify this patch? |
Could someone comment on what is the best way to add various package support? There are a large number of packages that may need installed to support various pypi packages that compile c code. Is the intention that a end user would fork sti-python and add whatever they need? Or should sti-python attempt to support most pypi packages out of box - which I think means adding quite a lot of packages to the base Docker image. For instance many cryptography and image python packages have C dependencies which require additional rpms to be installed. |
This patch is to support most django related projects which depend on jpeg. I know this could get crazy, but this is quite common. |
@bparees PTAL |
@bufke it's pretty case by case so far, we don't have a hard and fast rule. you've outlined the two options perfectly :) basically i'd say the process is:
|
@bparees I think this needs to be post-reviewed :)
$ docker images | grep jpeg
python-27-jpeg latest 15639fcae25f 29 seconds ago 657.7 MB
python-27-no-jpeg latest 804931d10c74 2 days ago 654.8 MB Something else to consider? |
@rhcarvalho sure. @donnydavis can you elaborate on why you consider this to be a common dependency? |
@donnydavis @bparees let's please move the discussion to a new issue to facilitate tracking of status and completion of necessary follow ups: |
@rhcarvalho +1 |
Added the correct packages
libjpeg-turbo libjpeg-turbo-devel