Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected pkgs libjpeg-turbo libjpeg-turbo-devel #102

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

donnydavis
Copy link

Added the correct packages
libjpeg-turbo libjpeg-turbo-devel

Added the correct packages 
libjpeg-turbo libjpeg-turbo-devel
@openshift-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@bufke
Copy link

bufke commented Feb 20, 2016

Could someone comment on what is the best way to add various package support? There are a large number of packages that may need installed to support various pypi packages that compile c code. Is the intention that a end user would fork sti-python and add whatever they need? Or should sti-python attempt to support most pypi packages out of box - which I think means adding quite a lot of packages to the base Docker image. For instance many cryptography and image python packages have C dependencies which require additional rpms to be installed.

@donnydavis
Copy link
Author

This patch is to support most django related projects which depend on jpeg. I know this could get crazy, but this is quite common.

@rhcarvalho
Copy link
Contributor

@bparees PTAL

@bparees
Copy link
Collaborator

bparees commented Mar 30, 2016

@bufke it's pretty case by case so far, we don't have a hard and fast rule. you've outlined the two options perfectly :)

basically i'd say the process is:

  1. if you need it now, create your own image based on sti-python
  2. if you have some time, open a pull and we'll discuss the merits of including those packages for everyone

@bparees bparees merged commit 529c67c into sclorg:master Mar 30, 2016
@rhcarvalho
Copy link
Contributor

@bparees I think this needs to be post-reviewed :)

  • It's unclear what apps or Python libraries that depend on those libs. Perhaps it doesn't belong in the Python layer, but in sti-base? Or in a specialized derivative of sti-python?
  • The patch was applied only to the 2.7 image (we could update 3.3 and 3.4 in a follow up)
  • The increase in image size is of ~3 MB
$ docker images | grep jpeg
python-27-jpeg                                      latest              15639fcae25f        29 seconds ago      657.7 MB
python-27-no-jpeg                                   latest              804931d10c74        2 days ago          654.8 MB

Something else to consider?

@bparees
Copy link
Collaborator

bparees commented Apr 1, 2016

@rhcarvalho sure. @donnydavis can you elaborate on why you consider this to be a common dependency?

@rhcarvalho
Copy link
Contributor

@donnydavis @bparees let's please move the discussion to a new issue to facilitate tracking of status and completion of necessary follow ups:
#109

@bparees
Copy link
Collaborator

bparees commented Apr 1, 2016

@rhcarvalho +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants