Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide better access to test logs #132

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

zmiklank
Copy link
Contributor

@zmiklank zmiklank commented Mar 7, 2024

Related: #130

@jamacku PTAL.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (6d060a1) to head (7eebb05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   99.29%   99.28%   -0.01%     
==========================================
  Files           8        8              
  Lines         564      563       -1     
  Branches       61       61              
==========================================
- Hits          560      559       -1     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thrix
Copy link
Contributor

thrix commented Mar 7, 2024

@zmiklank
Copy link
Contributor Author

zmiklank commented Mar 8, 2024

Hi @thrix. Yes, it seems we stopped showing the tests log URL in our logs in v2.

@phracek
Copy link
Member

phracek commented Mar 8, 2024

AS far as I know, it was present in Bash version. See here:

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I looked at code and did not hit any issue.

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmiklank, please also add tests for the new output so we do not cause regressions later.

For reference:

// Test outputs
expect(process.env['OUTPUT_REQUEST_ID']).toMatchInlineSnapshot('"1"');
expect(process.env['OUTPUT_REQUEST_URL']).toMatchInlineSnapshot(
'"https://api.dev.testing-farm.io/requests/1"'
);

@zmiklank
Copy link
Contributor Author

zmiklank commented Mar 8, 2024

@zmiklank, please also add tests for the new output so we do not cause regressions later.

Good catch, thanks. Added.

Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmiklank zmiklank merged commit ea32452 into sclorg:main Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants