Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse tmt inputs that contain = (e.g. BASE64 encoded strings) #179

Merged
merged 1 commit into from
May 2, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 2, 2024

No description provided.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (080971e) to head (f3e49f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   99.32%   99.32%   -0.01%     
==========================================
  Files           8        8              
  Lines         592      591       -1     
  Branches       69       68       -1     
==========================================
- Hits          588      587       -1     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing issue #178 .

What I can say from my point of view. I totally understand this code. LGTM.

@phracek phracek merged commit ed5e0c3 into sclorg:main May 2, 2024
7 checks passed
@jamacku jamacku deleted the base64 branch May 2, 2024 08:38
@henrywang
Copy link

henrywang commented May 3, 2024

Thanks @jamacku for fixing this issue. Thanks @phracek for your help on issue debugging.
I run the test on @main on PR virt-s1/bootc-workflow-test#294. The fix works in my case.
I'll update both https://github.com/containers/bootc and https://github.com/virt-s1/bootc-workflow-test to v2 when it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants