Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job summary link 🔗 #188

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: job summary link 🔗 #188

merged 1 commit into from
May 29, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 27, 2024

No description provided.

@jamacku jamacku requested a review from phracek May 27, 2024 07:07
@jamacku jamacku linked an issue May 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (2c15ff2) to head (44797a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   88.32%   88.33%   +0.01%     
==========================================
  Files          10       10              
  Lines         685      686       +1     
  Branches       72       72              
==========================================
+ Hits          605      606       +1     
  Misses         78       78              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmiklank
Copy link
Collaborator

[test]

@zmiklank
Copy link
Collaborator

Thanks for the PR, it works. However, I think we should provide the Test Logs, not pipeline log, when infra state is OK. But this is not a strong opinion.
image

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @zmiklank Not pipeline log, but directly logs, like here: sclorg/httpd-container#208

@jamacku
Copy link
Member Author

jamacku commented May 28, 2024

Like this?

ComposeArchInfrastructure StateTest resultLink to logs
Fedora-latestx86_64OKsuccesstest pipeline

@zmiklank
Copy link
Collaborator

Like this?

Yes, seems nice. :)

@zmiklank
Copy link
Collaborator

[test]

Copy link
Collaborator

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@zmiklank zmiklank merged commit f965d7f into sclorg:main May 29, 2024
10 of 11 checks passed
@jamacku jamacku deleted the link branch May 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test artifacts URL in Action summary clickable
3 participants