Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout test ⏲️ #197

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix timeout test ⏲️ #197

merged 1 commit into from
Jun 20, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jun 11, 2024

follow-up to #181

The original implementation of the test doesn't work as expected:

https://github.com/sclorg/testing-farm-as-github-action/actions/runs/9462296603/job/26064932008

@jamacku jamacku requested a review from phracek June 11, 2024 10:46
@jamacku

This comment was marked as off-topic.

Copy link
Collaborator

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Only one nitpick with comments, but I am also OK with merging this as it is.

@jamacku jamacku merged commit 60d633f into sclorg:main Jun 20, 2024
8 of 9 checks passed
@jamacku jamacku deleted the timeout branch June 20, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants