Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High contrast mode findings #4

Merged
merged 2 commits into from Jan 6, 2022
Merged

Conversation

fscholdei
Copy link
Member

@fscholdei fscholdei commented Jan 5, 2022

Proposed changes

Correct high contrast mode findings scm-manager/scm-manager#1892.

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog or CHANGELOG.md is updated for plugins
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@fscholdei fscholdei added the enhancement New feature or request label Jan 5, 2022
@pfeuffer pfeuffer merged commit bd996d3 into develop Jan 6, 2022
@pfeuffer pfeuffer deleted the feature/high_contrast_findings branch January 6, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants